import-boss reverse import #83526

eloyekunle · 2019-10-05T10:34:00Z

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR adds reverse import restrictions for packages by import-boss.

Reverse import restrictions help to define which packages in k/k can import certain other packages, defined inside the latter. This allows to have fine-grained import restrictions for "private packages" where we don't want to spread use inside of k/k.

The import-restrictions files added here specify that the apiextensions-apiserver package (and subpackages, except v1 and v1beta1) should only be used in apiserver, and not anywhere else.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Ref: kubernetes/gengo#154

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig api-machinery

eloyekunle · 2019-10-05T11:08:03Z

/priority important-longterm

eloyekunle · 2019-10-07T08:54:48Z

/cc @sttts

…beta1

eloyekunle · 2020-01-28T09:59:34Z

ping @liggitt

sttts · 2020-01-28T10:27:12Z

pkg/controller/.import-restrictions

-        "google.golang.org/api/tpu/v1",
-        "golang.org/x/net/context",
-        "google.golang.org/grpc"
-      ]


these removals look good to me. This is not the intended use of import-boss.

sttts · 2020-01-28T10:27:42Z

pkg/cloudprovider/providers/.import-restrictions

-				"k8s.io/utils/path",
-				"k8s.io/utils/strings"
-			]
-		},
 		{


lgtm. k8s.io/utils is not a staging repo and we should not restrict use.

sttts · 2020-01-28T10:29:22Z

/lgtm
/approve

sttts · 2020-01-28T10:50:13Z

/lgtm

fejta-bot · 2020-01-28T10:58:30Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

liggitt

/lgtm
/approve

liggitt · 2020-01-28T13:18:35Z

pkg/master/controller/clusterauthenticationtrust/cluster_authentication_trust_controller.go

@@ -109,7 +108,7 @@ func NewClusterAuthenticationTrustController(requiredAuthenticationData ClusterA
 				return cast.Name == configMapName
 			}
 			if tombstone, ok := obj.(cache.DeletedFinalStateUnknown); ok {
-				if cast, ok := tombstone.Obj.(*apiextensions.CustomResourceDefinition); ok {
+				if cast, ok := tombstone.Obj.(*corev1.ConfigMap); ok {


that's exciting

Very exciting 😁

k8s-ci-robot · 2020-01-28T13:20:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eloyekunle, liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [liggitt]
~~staging/src/k8s.io/apiextensions-apiserver/pkg/apis/OWNERS~~ [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2020-01-29T00:38:40Z

@eloyekunle: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kubernetes-e2e-gce-iscsi	6aeee39bb9a5c899ff47f32c43a4c7ba1cf2fbb5	link	`/test pull-kubernetes-e2e-gce-iscsi`
pull-kubernetes-e2e-gce-alpha-features	6aeee39bb9a5c899ff47f32c43a4c7ba1cf2fbb5	link	`/test pull-kubernetes-e2e-gce-alpha-features`
pull-kubernetes-e2e-gci-gce-autoscaling	6aeee39bb9a5c899ff47f32c43a4c7ba1cf2fbb5	link	`/test pull-kubernetes-e2e-gci-gce-autoscaling`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

eloyekunle · 2020-01-29T00:45:34Z

/retest

…

On Wed, 29 Jan 2020, 01:38 Kubernetes Prow Robot, ***@***.***> wrote: @eloyekunle <https://github.com/eloyekunle>: The following tests *failed*, say /retest to rerun all failed tests: Test name Commit Details Rerun command pull-kubernetes-e2e-gce-iscsi 6aeee39 <6aeee39> link <https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/83526/pull-kubernetes-e2e-gce-iscsi/1216779292105510913/> /test pull-kubernetes-e2e-gce-iscsi pull-kubernetes-e2e-gce-alpha-features 6aeee39 <6aeee39> link <https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/83526/pull-kubernetes-e2e-gce-alpha-features/1216778788843556866/> /test pull-kubernetes-e2e-gce-alpha-features pull-kubernetes-e2e-gci-gce-autoscaling 6aeee39 <6aeee39> link <https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/83526/pull-kubernetes-e2e-gci-gce-autoscaling/1216779292105510914/> /test pull-kubernetes-e2e-gci-gce-autoscaling pull-kubernetes-kubemark-e2e-gce-big bae4ff5 <bae4ff5> link <https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/83526/pull-kubernetes-kubemark-e2e-gce-big/1222288609051152384/> /test pull-kubernetes-kubemark-e2e-gce-big Full PR test history <https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=83526>. Your PR dashboard <https://gubernator.k8s.io/pr/eloyekunle>. Please help us cut down on flakes by linking to <https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests> an open issue <https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when you hit one in your PR. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#83526?email_source=notifications&email_token=ACVGJVOAZS7RX3Z4A6HBD3LRADFZJA5CNFSM4I5XHEMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKFRMCY#issuecomment-579540491>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACVGJVLRDUDR3UGL6JNNKBDRADFZJANCNFSM4I5XHEMA> .

…e-import import-boss reverse import Kubernetes-commit: f5a0087

k8s-ci-robot requested review from justinsb and smarterclayton October 5, 2019 10:34

k8s-ci-robot added area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Oct 5, 2019

eloyekunle force-pushed the feat/gengo-reverse-import branch from ffff7a9 to 058a140 Compare October 5, 2019 11:44

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 5, 2019

k8s-ci-robot requested a review from sttts October 7, 2019 08:54

eloyekunle force-pushed the feat/gengo-reverse-import branch from 058a140 to 5a260fc Compare October 7, 2019 09:31

eloyekunle added 3 commits January 28, 2020 10:51

add import-restrictions to apiextensions-apiserver/pkg/apis,v1 and v1…

db19fc9

…beta1

add staging directories to import-boss verify script

558f6aa

bump gengo version

cece51b

eloyekunle force-pushed the feat/gengo-reverse-import branch from 68c1285 to cece51b Compare January 28, 2020 09:58

eloyekunle changed the title ~~WIP: import-boss reverse import~~ import-boss reverse import Jan 28, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2020

sttts reviewed Jan 28, 2020

View reviewed changes

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 28, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2020

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2020

fix apiextensions reference in controller/clusterauthenticationtrust

bae4ff5

eloyekunle force-pushed the feat/gengo-reverse-import branch from fef87de to bae4ff5 Compare January 28, 2020 13:11

liggitt reviewed Jan 28, 2020

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2020

ahg-g mentioned this pull request Jan 28, 2020

Remove pkg/scheduler/volumebinder. #87450

Closed

k8s-ci-robot merged commit f5a0087 into kubernetes:master Jan 29, 2020

k8s-ci-robot added this to the v1.18 milestone Jan 29, 2020

eloyekunle deleted the feat/gengo-reverse-import branch February 5, 2020 10:39

liggitt removed the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Feb 18, 2020

wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020

Merge pull request kubernetes#83526 from eloyekunle/feat/gengo-revers…

523ed9a

…e-import import-boss reverse import Kubernetes-commit: f5a0087

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

import-boss reverse import #83526

import-boss reverse import #83526

eloyekunle commented Oct 5, 2019 •

edited

eloyekunle commented Oct 5, 2019

eloyekunle commented Oct 7, 2019

eloyekunle commented Jan 28, 2020

sttts Jan 28, 2020 •

edited

sttts Jan 28, 2020

sttts commented Jan 28, 2020

sttts commented Jan 28, 2020

fejta-bot commented Jan 28, 2020

liggitt left a comment

liggitt Jan 28, 2020

eloyekunle Jan 28, 2020

k8s-ci-robot commented Jan 28, 2020

k8s-ci-robot commented Jan 29, 2020 •

edited

eloyekunle commented Jan 29, 2020 via email

import-boss reverse import #83526

import-boss reverse import #83526

Conversation

eloyekunle commented Oct 5, 2019 • edited

eloyekunle commented Oct 5, 2019

eloyekunle commented Oct 7, 2019

eloyekunle commented Jan 28, 2020

sttts Jan 28, 2020 • edited

Choose a reason for hiding this comment

sttts Jan 28, 2020

Choose a reason for hiding this comment

sttts commented Jan 28, 2020

sttts commented Jan 28, 2020

fejta-bot commented Jan 28, 2020

liggitt left a comment

Choose a reason for hiding this comment

liggitt Jan 28, 2020

Choose a reason for hiding this comment

eloyekunle Jan 28, 2020

Choose a reason for hiding this comment

k8s-ci-robot commented Jan 28, 2020

k8s-ci-robot commented Jan 29, 2020 • edited

eloyekunle commented Jan 29, 2020 via email

eloyekunle commented Oct 5, 2019 •

edited

sttts Jan 28, 2020 •

edited

k8s-ci-robot commented Jan 29, 2020 •

edited